Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental video download support #366

Merged
merged 13 commits into from
May 28, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented May 5, 2022

Settings Screen New Download Download Complete Edit Downloads Delete Confirmation
CEAD1867-2BD0-4FA2-BF3F-C5A6AB87270D AD344BF4-FA3C-43C8-99B5-7B274F68E543 1D25C001-0844-4731-94AD-B929C3C31982 6B6BF62E-2173-4347-B02F-53F9768FDC30 7EA67762-C8D8-4344-8453-EE48E0C7B17C

This will definitely require some follow-up work, but I didn't want this PR to get any bigger.

Follow-up work is covered by #372

Fixes #22

@thornbill thornbill added the enhancement Improve existing functionality or small fixes label May 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented May 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented May 5, 2022

Codecov Report

Merging #366 (ab2159f) into master (38b6a93) will decrease coverage by 1.24%.
The diff coverage is 54.24%.

@@            Coverage Diff             @@
##           master     #366      +/-   ##
==========================================
- Coverage   61.84%   60.60%   -1.25%     
==========================================
  Files          41       46       +5     
  Lines         781      929     +148     
  Branches      162      186      +24     
==========================================
+ Hits          483      563      +80     
- Misses        270      333      +63     
- Partials       28       33       +5     
Impacted Files Coverage Δ
App.js 0.00% <0.00%> (ø)
components/NativeShellWebView.js 15.38% <0.00%> (-1.29%) ⬇️
navigation/TabNavigator.js 0.00% <0.00%> (ø)
screens/DevSettingsScreen.js 45.45% <0.00%> (-17.05%) ⬇️
screens/DownloadScreen.js 35.84% <35.84%> (ø)
screens/HomeScreen.js 55.88% <66.66%> (+0.65%) ⬆️
components/DownloadListItem.js 100.00% <100.00%> (ø)
models/DownloadModel.ts 100.00% <100.00%> (ø)
stores/DownloadStore.ts 100.00% <100.00%> (ø)
stores/MediaStore.js 100.00% <100.00%> (ø)
... and 3 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pinkworld123

This comment was marked as off-topic.

@thornbill thornbill marked this pull request as ready for review May 26, 2022 14:02
@thornbill thornbill merged commit 9c1d5c5 into jellyfin:master May 28, 2022
@thornbill thornbill deleted the downloads-remux branch May 28, 2022 03:50
@thornbill thornbill added this to the v1.6.0 milestone May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve existing functionality or small fixes
Development

Successfully merging this pull request may close these issues.

Download feature doesn't appear to work
3 participants