Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dependencies and version #120

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Bump dependencies and version #120

merged 2 commits into from
Mar 23, 2022

Conversation

Shadowghost
Copy link
Contributor

@Shadowghost Shadowghost commented Mar 23, 2022 •
edited
Loading

  • Bump dependencies
  • Add changelog
  • Bump ffmpeg version to -4

Note:

@nyanmisaka
Copy link
Member

Have you verified gmmlib 22.1.1 with compute-runtime's gmmlib 22.0.2?

The last time I tried 22.0.3 it broke the command ffmpeg -v verbose -init_hw_device vaapi=va:,driver=iHD -init_hw_device qsv=qs@va -init_hw_device opencl=ocl@va and throw segfault error.

@nyanmisaka
Copy link
Member

nyanmisaka commented Mar 23, 2022 •
edited
Loading

Keeping the version of nv-codec-headers at 11.0.10.1 is to provide forward compatibility where possible.
11.0.10.1 requires 455/456 driver but the latest 11.1.5.1 requires 470/471 driver. Both of them support AV1 decoding.

https://github.com/FFmpeg/nv-codec-headers/blob/n11.0.10.1/README
https://github.com/FFmpeg/nv-codec-headers/blob/n11.1.5.1/README

@Shadowghost Shadowghost force-pushed the bump branch 2 times, most recently from 9b57d20 to 484608f Compare March 23, 2022 07:42
@Shadowghost
Copy link
Contributor Author

Shadowghost commented Mar 23, 2022 •
edited
Loading

Have you verified gmmlib 22.1.1 with compute-runtime's gmmlib 22.0.2?

The last time I tried 22.0.3 it broke the command ffmpeg -v verbose -init_hw_device vaapi=va:,driver=iHD -init_hw_device qsv=qs@va -init_hw_device opencl=ocl@va and throw segfault error.

It segfaulted for me too with 22.1.1 (there is a commit to fix the segfault in master, but not in a release version).

I'm currently trying 22.0.3. If that segfaults too I'll just let it be at 22.0.2 (though I don't see why 22.0.3 would break compatibility with 22.0.2 since ABI changes require a major version bump as per readme)

@nyanmisaka
Copy link
Member

nyanmisaka commented Mar 23, 2022 •
edited
Loading

it's related to GmmLib ABI broken by intel/gmmlib@8dcebfe, please update media code after intel/media-driver@79c20b78a and gmmlib code after intel/gmmlib@29152fc

The regression code was added in gmmlib 22.0.3. intel/media-driver#1364 (comment)
I have reverted it in #112

@Shadowghost
Copy link
Contributor Author

Shadowghost commented Mar 23, 2022 •
edited
Loading

I reverted to 22.0.2 but I'll check again after they released the new tag.
Should be fine to use the tag when available. I built it with gmmlib master and everything seems to work fine (105 fps on a 4k HDR SRT -> 1080p SDR stream on an UHD630)

@Shadowghost Shadowghost marked this pull request as ready for review March 23, 2022 19:32
@joshuaboniface joshuaboniface merged commit aea6bec into jellyfin:jellyfin Mar 23, 2022
@Shadowghost Shadowghost deleted the bump branch March 4, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shadowghost @nyanmisaka @joshuaboniface