Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GitHub Actions workflow #66

Merged
merged 9 commits into from
Sep 6, 2021
Merged

Add GitHub Actions workflow #66

merged 9 commits into from
Sep 6, 2021

Conversation

daullmer
Copy link
Member

  • Add GitHub Action for building Linux Packages
  • Change build script to allow for different .deb location

@daullmer
Copy link
Member Author

Sample run with #65 merged: https://github.com/Ullmie02/jellyfin-ffmpeg/actions/runs/736216721

h1dden-da3m0n
h1dden-da3m0n reviewed Apr 10, 2021
View reviewed changes
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mind me also asking why you split off the release workflow off the main? (theoretically you could extent the mains triggers and run the publish job only if its the correct trigger and with needs: build?)

.github/workflows/release.yml Outdated Show resolved Hide resolved
h1dden-da3m0n
h1dden-da3m0n reviewed Apr 10, 2021
View reviewed changes
.github/workflows/main.yml Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
h1dden-da3m0n
h1dden-da3m0n approved these changes May 25, 2021
View reviewed changes
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for catching the rsync arguments 😅 👍

h1dden-da3m0n
h1dden-da3m0n approved these changes Sep 5, 2021
View reviewed changes
Copy link
Contributor

@h1dden-da3m0n h1dden-da3m0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't there also one Distro version that would not build due to outdated deps? if so should we not remove them (can be done in another PR)

.github/workflows/main.yml Outdated Show resolved Hide resolved
@daullmer
Copy link
Member Author

daullmer commented Sep 6, 2021

I removed the release part of the workflow and will add it again in a later PR because the collect-ffmpeg.sh Script is still missing

@joshuaboniface joshuaboniface merged commit 9d59e91 into jellyfin:jellyfin Sep 6, 2021
@daullmer daullmer deleted the gh-actions branch September 6, 2021 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@h1dden-da3m0n h1dden-da3m0n h1dden-da3m0n approved these changes

@ferferga ferferga ferferga approved these changes

@joshuaboniface joshuaboniface joshuaboniface approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@daullmer @joshuaboniface @ferferga @h1dden-da3m0n