Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setting for custom options for mpv #441

Closed
dharmik2319 opened this issue May 19, 2023 · 4 comments
Closed

Add setting for custom options for mpv #441

dharmik2319 opened this issue May 19, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@dharmik2319
Copy link

Is your feature request related to a problem? Please describe.
Recently, when starting an h264 8-bit video on my AMD iGPU with mpv, I faced a black screen with only subtitles and audio. See mpv-player/mpv#3714. I noticed that i faced the same problem with Jellyfin Media Player as well and was getting the same error message. I was able to solve the mpv issue by commenting out the mpv.conf file, which had just one line: hwdec=vaapi. Another workaround was using --no-config in the cli.

I copied the mpv.conf file to the directory containing jellyfinmediaplayer.conf but the problem persisted and the mpv.conf file was getting overridden.

Describe the solution you'd like
Give the user an option for custom mpv options, or even better, an option to select another player.

Describe alternatives you've considered
As stated before, the mpv.conf got overridden

@dharmik2319 dharmik2319 added the enhancement New feature or request label May 19, 2023
@kradear
Copy link

kradear commented May 20, 2023

mpv.conf ignores most if not all commands I use on MPV for JMP.

I've read of users being able to use settings as sub-pos or volume-max to modify JMP, but it's current version doesn't seem to take any them.

I've looked around but found no way of setting these or adding/modifying input settings for JMP. The keyboard.json options don't seem to take effect if not using the "TV mode" of JMP.

I couldn't find talks about adding these features to the app, but it would a first step on replacing external players for good.
Being able to use mpv.conf and input.conf on JMP would open full customization.

@satmandu
Copy link
Contributor

The mpv.conf settings appear to be read here:

// Configuration properties defined in the mpv.conf will override our

  // Configuration properties defined in the mpv.conf will override our
  // hardcoded properties below.
  mpv::qt::set_property(m_mpv, "config", "yes");
  mpv::qt::set_property(m_mpv, "config-dir", Paths::dataDir());

If that's not working, maybe you could try some debug code to make sure the right dir for the mpv.conf file is being used?

@sevenrats
Copy link
Member

this functionality works. some items like subposition and size are overruled by client settings. that discussion is happening here:
#474

@sevenrats sevenrats closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2024
@sevenrats
Copy link
Member

#543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

4 participants