Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtitles position #474

Closed
Knetsu opened this issue Aug 12, 2023 · 5 comments
Closed

subtitles position #474

Knetsu opened this issue Aug 12, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@Knetsu
Copy link

Knetsu commented Aug 12, 2023

Is there an option to move the position subtitles? It would be of great help for people who want to move the subtitles position. Should there be an option on the keyboard, or how can I modify the jellyfinmediaplayer.conf that I should add?

@sevenrats
Copy link
Member

subtitles are positioned using an mpv.conf file in the normal way. the docs will show you where to put the conf file. if you have trouble finding it, stop by one of the chat spaces and somebody will help you.

@florentc
Copy link

florentc commented Jan 4, 2024

This is not true. Subtitle position cannot be modified in mpv.conf on version 1.9.1.

The sub-pos option in mpv.conf is ignored and overridden by the subtitles.placement option in jellyfinmediaplayer.conf.
Same issue with sub-color.
However, sub-bold is taken into account for example.

I think this issue should be reopen @sevenrats.

@sevenrats sevenrats reopened this Jan 4, 2024
@sevenrats
Copy link
Member

can you help the reader understand why the current options are insufficient?

@florentc
Copy link

florentc commented Jan 5, 2024

Thank you for reopening the issue. The current options are insufficient because the right subtitle position can be a matter of a few dozens of pixels on the screen.

The current options for vertical position are basically top and bottom on the edge of the screen.

Some people struggle to read subtitles that are too far from the center of their vision because of vision impairment. Some users are just used to centered subtitles (see #289). Some users view content that already includes text on the edge of the screen (or other important information) which, if not taken into account by the subtitles, may be hidden by the subtitles and require a slight offset to the top or bottom for comfort. That offset would conveniently put the subtitles in an intermediate vertical position that is neither top edge, middle, or bottom edge. Every user might have their sweet spot for subtitles in an intermediate position for various reasons.

There are many use cases for fine-tuned vertical position. I think it would be nice if the sub-pos options in mpv.conf was taken into account when present. Or if the subtitle.placement option in jellyfinmediaplayer.conf allowed for values between 0 and 100 for horizontal and vertical position (see #284). Or at least adding a center option for vertical position, and maybe slightlyTop, slightlyBottom.

@sevenrats
Copy link
Member

@florentc after reviewing a broader set of the reported issues, its clear that this is a widespread and complex issue. I am unifying all of these under a new dicussion threadm because its not immediately clear what the best way to satisfy everybody's needs is. This thread will be linked there, and if you have anything to add, I think here or there is perfectly appropriate.
#543

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

3 participants