-
-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix removing trailing slash making JMP unable to connect to some servers #755
Conversation
Apologize if that doesn't 100% fit to the contribution guidelines, it's my fist contribution. Let me know how I can improve this PR! |
Hopefully this fixes #684 that has been driving me insane for months. And thank you for the contribution ❤️ Update: It did fix the issue, thank you again. |
@xAphex I wish so! By any chance, do you how's the approval process like on this project? Should I assign someone? Basically there was no action for the last 2 days... |
@iwalton3 is the one responsible over this project, hopefully she can merge this contribution with the project and release a minor update |
@iwalton3 Can you please push a new 1.11.2 version with the fix, thank you. |
Hello, i am just a normal End User but i cant connect with my JMP on Windwos but i can Connect on anything else. I Thin i have a Problem that can ne solved with this fix above. But i have no f*** clue what to do. Can someone help me? Greetings Chris |
Download this file: https://github.com/jellyfin/jellyfin-media-player/blob/master/native/find-webclient.js and put it in it will ask you to replace the existing file, press yes, and that's it. |
YOU ARE A FUCKING LEGEND!!! OMG Thank you so much, this fixed my Problem :D |
Resolves issue #754.
My proposal is to leave the trailing slash for connecting to the Jellyfin server (l.12) and strip it out only for accessing metadata at "/System/Info/Public"