Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix removing trailing slash making JMP unable to connect to some servers #755

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

fredguile
Copy link
Contributor

Resolves issue #754.

My proposal is to leave the trailing slash for connecting to the Jellyfin server (l.12) and strip it out only for accessing metadata at "/System/Info/Public"

@fredguile
Copy link
Contributor Author

Apologize if that doesn't 100% fit to the contribution guidelines, it's my fist contribution. Let me know how I can improve this PR!

@xAphex
Copy link

xAphex commented Sep 4, 2024

Hopefully this fixes #684 that has been driving me insane for months.

And thank you for the contribution ❤️

Update: It did fix the issue, thank you again.

@fredguile
Copy link
Contributor Author

@xAphex I wish so! By any chance, do you how's the approval process like on this project? Should I assign someone? Basically there was no action for the last 2 days...

@xAphex
Copy link

xAphex commented Sep 5, 2024

@xAphex I wish so! By any chance, do you how's the approval process like on this project? Should I assign someone? Basically there was no action for the last 2 days...

@iwalton3 is the one responsible over this project, hopefully she can merge this contribution with the project and release a minor update

@iwalton3 iwalton3 merged commit d0f27ce into jellyfin:master Sep 20, 2024
@xAphex
Copy link

xAphex commented Sep 20, 2024

@iwalton3 Can you please push a new 1.11.2 version with the fix, thank you.

@DerChris119
Copy link

Hello,

i am just a normal End User but i cant connect with my JMP on Windwos but i can Connect on anything else. I Thin i have a Problem that can ne solved with this fix above. But i have no f*** clue what to do. Can someone help me?

Greetings Chris

@xAphex
Copy link

xAphex commented Sep 23, 2024

Hello,

i am just a normal End User but i cant connect with my JMP on Windwos but i can Connect on anything else. I Thin i have a Problem that can ne solved with this fix above. But i have no f*** clue what to do. Can someone help me?

Greetings Chris

Download this file: https://github.com/jellyfin/jellyfin-media-player/blob/master/native/find-webclient.js

and put it in C:\Program Files\Jellyfin\Jellyfin Media Player\web-client\extension

it will ask you to replace the existing file, press yes, and that's it.

@DerChris119
Copy link

YOU ARE A FUCKING LEGEND!!! OMG Thank you so much, this fixed my Problem :D

@fredguile
Copy link
Contributor Author

@iwalton3 how about releasing 1.11.2 with the fix? I've opened #766, would that work?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants