Add option to fallback to original language (#156)

jellyfin · Jun 24, 2024 · a3e485a · a3e485a
1 parent f247a33
commit a3e485a
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 6 deletions.
diff --git a/Jellyfin.Plugin.Tvdb/Configuration/PluginConfiguration.cs b/Jellyfin.Plugin.Tvdb/Configuration/PluginConfiguration.cs
@@ -59,5 +59,10 @@ public int MetadataUpdateInHours
         /// Gets or sets a value indicating whether to include missing specials.
         /// </summary>
         public bool IncludeMissingSpecials { get; set; } = true;
+
+        /// <summary>
+        /// Gets or sets a value indicating whether to fallback to original language.
+        /// </summary>
+        public bool FallbackToOriginalLanguage { get; set; } = false;
     }
 }
diff --git a/Jellyfin.Plugin.Tvdb/Configuration/config.html b/Jellyfin.Plugin.Tvdb/Configuration/config.html
@@ -53,6 +53,10 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                         <input is="emby-checkbox" type="checkbox" id="includeMissingSpecials" />
                         <span>Include missing specials</span>
                     </label>
+                    <label class="checkboxContainer">
+                        <input is="emby-checkbox" type="checkbox" id="fallbackToOriginalLanguage" />
+                        <span>Fallback to Original Language (Last resort if other fallback languages fails)</span>
+                    </label>
                     <br />
                     <div>
                         <button is="emby-button" type="submit" data-theme="b" class="raised button-submit block">
@@ -77,6 +81,7 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                     document.getElementById('metadataUpdateInHours').value = config.MetadataUpdateInHours;
                     document.getElementById('fallbackLanguages').value = config.FallbackLanguages;
                     document.getElementById('includeMissingSpecials').checked = config.IncludeMissingSpecials;
+                    document.getElementById('fallbackToOriginalLanguage').checked = config.FallbackToOriginalLanguage;
                     Dashboard.hideLoadingMsg();
                 });
             },
@@ -91,6 +96,7 @@ <h2 class="sectionTitle">TheTVDB Settings:</h2>
                     config.MetadataUpdateInHours = document.getElementById('metadataUpdateInHours').value;
                     config.FallbackLanguages = document.getElementById('fallbackLanguages').value;
                     config.IncludeMissingSpecials = document.getElementById('includeMissingSpecials').checked;
+                    config.FallbackToOriginalLanguage = document.getElementById('fallbackToOriginalLanguage').checked;
                     ApiClient.updatePluginConfiguration(TvdbPluginConfiguration.uniquePluginId, config).then(function (result) {
                         Dashboard.processPluginConfigurationUpdateResult(result);
                     });

diff --git a/Jellyfin.Plugin.Tvdb/Providers/TvdbEpisodeProvider.cs b/Jellyfin.Plugin.Tvdb/Providers/TvdbEpisodeProvider.cs
@@ -217,8 +217,8 @@ private async Task<MetadataResult<Episode>> MapEpisodeToResult(EpisodeInfo id, E
                     IndexNumberEnd = id.IndexNumberEnd,
                     // Tvdb uses 3 letter code for language (prob ISO 639-2)
                     // Reverts to OriginalName if no translation is found
-                    Name = episode.Translations.GetTranslatedNamedOrDefault(id.MetadataLanguage) ?? episode.Name,
-                    Overview = episode.Translations.GetTranslatedOverviewOrDefault(id.MetadataLanguage) ?? episode.Overview,
+                    Name = episode.Translations.GetTranslatedNamedOrDefault(id.MetadataLanguage) ?? TvdbUtils.ReturnOriginalLanguageOrDefault(episode.Name),
+                    Overview = episode.Translations.GetTranslatedOverviewOrDefault(id.MetadataLanguage) ?? TvdbUtils.ReturnOriginalLanguageOrDefault(episode.Overview),
                     OriginalTitle = episode.Name,
                 }
             };

diff --git a/Jellyfin.Plugin.Tvdb/Providers/TvdbSeriesProvider.cs b/Jellyfin.Plugin.Tvdb/Providers/TvdbSeriesProvider.cs
@@ -152,8 +152,8 @@ private RemoteSearchResult MapSeriesToRemoteSearchResult(SeriesExtendedRecord se
         {
             var remoteResult = new RemoteSearchResult
             {
-                Name = series.Translations.GetTranslatedNamedOrDefault(language) ?? series.Name,
-                Overview = series.Translations.GetTranslatedOverviewOrDefault(language)?.Trim() ?? series.Overview?.Trim(),
+                Name = series.Translations.GetTranslatedNamedOrDefault(language) ?? TvdbUtils.ReturnOriginalLanguageOrDefault(series.Name),
+                Overview = series.Translations.GetTranslatedOverviewOrDefault(language)?.Trim() ?? TvdbUtils.ReturnOriginalLanguageOrDefault(series.Overview?.Trim()),
                 SearchProviderName = Name,
                 ImageUrl = series.Image
             };
@@ -446,8 +446,8 @@ private static void MapSeriesToResult(MetadataResult<Series> result, SeriesExten
             series.SetTvdbId(tvdbSeries.Id);
             // Tvdb uses 3 letter code for language (prob ISO 639-2)
             // Reverts to OriginalName if no translation is found
-            series.Name = tvdbSeries.Translations.GetTranslatedNamedOrDefault(info.MetadataLanguage) ?? tvdbSeries.Name;
-            series.Overview = tvdbSeries.Translations.GetTranslatedOverviewOrDefault(info.MetadataLanguage) ?? tvdbSeries.Overview;
+            series.Name = tvdbSeries.Translations.GetTranslatedNamedOrDefault(info.MetadataLanguage) ?? TvdbUtils.ReturnOriginalLanguageOrDefault(tvdbSeries.Name);
+            series.Overview = tvdbSeries.Translations.GetTranslatedOverviewOrDefault(info.MetadataLanguage) ?? TvdbUtils.ReturnOriginalLanguageOrDefault(tvdbSeries.Overview);
             series.OriginalTitle = tvdbSeries.Name;
             result.ResultLanguage = info.MetadataLanguage;
             series.AirDays = TvdbUtils.GetAirDays(tvdbSeries.AirsDays).ToArray();

diff --git a/Jellyfin.Plugin.Tvdb/TvdbUtils.cs b/Jellyfin.Plugin.Tvdb/TvdbUtils.cs
@@ -15,6 +15,8 @@ public static class TvdbUtils
         /// </summary>
         public const string TvdbBaseUrl = "https://www.thetvdb.com/";
 
+        private static bool FallbackToOriginalLanguage => TvdbPlugin.Instance?.Configuration.FallbackToOriginalLanguage ?? false;
+
         /// <summary>
         /// Converts SeriesAirsDays to DayOfWeek array.
         /// </summary>
@@ -57,5 +59,15 @@ public static IEnumerable<DayOfWeek> GetAirDays(SeriesAirsDays seriesAirsDays)
                 yield return DayOfWeek.Saturday;
             }
         }
+
+        /// <summary>
+        /// Returns the original language if fallback is enabled.
+        /// </summary>
+        /// <param name="text">String to return if fallback is enabled.</param>
+        /// <returns>string or null.</returns>
+        public static string? ReturnOriginalLanguageOrDefault(string? text)
+        {
+            return FallbackToOriginalLanguage ? text : null;
+        }
     }
 }