Update to Tvdb sdk 4.7.9.1 #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -272,13 +272,13 @@ | |||
| .ConfigureAwait(false); | |||
| var resultData = result; | |||
|
|
|||
| if (resultData is null || resultData.Count == 0 || resultData[0] is null || resultData[0].Series is null) | |||
| if (resultData is null || resultData.Count == 0 || resultData[0] is null || resultData[0].Series is null || resultData[0].Series.Id.HasValue == false) | |||
Check notice
Code scanning / CodeQL
Unnecessarily complex Boolean expression Note
| @@ -382,14 +382,14 @@ | |||
|
|
|||
| Data2 seriesData = seriesResponse.Data; | |||
|
|
|||
| if (seriesData == null || seriesData.Episodes == null || seriesData.Episodes.Count == 0) | |||
| if (seriesData == null || seriesData.Episodes == null || seriesData.Episodes.Count == 0 || seriesData.Episodes[0].Id.HasValue == false) | |||
Check notice
Code scanning / CodeQL
Unnecessarily complex Boolean expression Note
|
Hey @BobSilent, can you test out this branch and see if there is any serialization problems? Didn't catch any on my end. |
|
Sure, will do it later and write an update here |
👍 This much better now, at least I did not have any issues with serialization. 🚀 |
crobibero
approved these changes
Feb 29, 2024
crobibero
added
the
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to Tvdb sdk 4.7.9.1