-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Caching for api calls #118
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we want an option to reset the cache
@Shadowghost added a task with no default trigger to allow for purging of the cache |
I would have preferred a simple button in the settings to purge all TVdB cached data only. E.g. by adding a cancelationtoken to each entry when adding to cache.
As an option to resetting our cached data without the need to restart the whole application. Also I would like to have the cache time (e.g. min. Or hours only) configurable in the plug-in configuration ui, and maybe also disabled by setting the value to 0. |
This reverts commit df4fec4.
I do have another branch that allows for time configuration for cache. Will create the PR for that once this get merged. |
Caches the results from api calls for an hour. Caches Languages and ArtworkTypes for a day