Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IsMatch logic #188

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Fix IsMatch logic #188

merged 1 commit into from
Oct 28, 2024

Conversation

scampower3
Copy link
Member

@scampower3 scampower3 commented Oct 27, 2024 •
edited
Loading

Should not execute the below code for special mapped languages

return TvdbCultureInfo.GetCultureInfo(language!)?
    .ThreeLetterISOLanguageNames?
    .Contains(translation, StringComparer.OrdinalIgnoreCase)
    ?? false;

Fixes:#185

@scampower3 scampower3 added the bug This PR or Issue describes or fixes something that isn't working label Oct 27, 2024
@scampower3 scampower3 changed the title Fix is match logic Fix IsMatch logic Oct 27, 2024
@crobibero crobibero merged commit 62f0dec into jellyfin:master Oct 28, 2024
4 checks passed
@jellyfin-bot jellyfin-bot mentioned this pull request Oct 28, 2024
Merged
@scampower3 scampower3 deleted the fix-ismatch-logic branch October 29, 2024 01:12
@scampower3 scampower3 restored the fix-ismatch-logic branch October 30, 2024 01:31
@scampower3 scampower3 deleted the fix-ismatch-logic branch October 30, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shadowghost Shadowghost Shadowghost approved these changes

Assignees
No one assigned
Labels
bug This PR or Issue describes or fixes something that isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scampower3 @Shadowghost @crobibero