Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "unkown" to cast role if meta is missing #1032

Closed
candry7731 opened this issue Feb 17, 2023 · 3 comments · Fixed by #1055
Closed

Add "unkown" to cast role if meta is missing #1032

candry7731 opened this issue Feb 17, 2023 · 3 comments · Fixed by #1055
Labels
enhancement New feature or request

Comments

@candry7731
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently, if a cast member is missing role metadata then the secondary text is "as" then a blank

Describe the solution you'd like
Like to add the work "unknown" after the "as" if there is no role metadata

Additional context

Missing role data
image

Add "unknown" (just the text, not the background)
image

@candry7731 candry7731 added the enhancement New feature or request label Feb 17, 2023
@cewert
Copy link
Member

cewert commented Feb 22, 2023

Maybe we should also move the "unknown"s to the end of the Cast & Crew list? Your screenshot shows a list of 19 people and the first 5 are missing a picture and don't have a known role. If possible, I think we should sort the list based on available metadata like picture and role.

@candry7731
Copy link
Contributor Author

@cewert I like that Idea. I wonder how we could sort it?

@cewert
Copy link
Member

cewert commented Feb 22, 2023

I checked a few movies of mine and all the ones I checked were sorted just like the web client - with actors at the front of the list sorted by billing i think followed by directors etc.. So I'm thinking this is a fluke and your metadata is just messed up for that movie. What does the cast for that movie look like when you view it on the web client?

If I remember correctly brightscright arrays don't support sorting so we'd have to hack something together. It's totally possible but would be ugly and slow I think. Hopefully its just a metadata issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants