Show "Actor" when an actor has an empty role #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@candry7731 this is what I meant. Can you give it a test and tell me how it works for you? |
|
I am getting an error.
|
|
|
|
@candry7731 sorry wrong function. It should work now |
|
@candry7731 can you give this a test please? |
candry7731
approved these changes
Mar 15, 2023
|
@candry7731 thanks for testing I'm glad it works. Do you want to use this PR instead of #1034? |
|
Yes, I closed the other PR. Do you think having the secondary text scroll would be nice? Sometimes the name is cut off or the character name is cut off.... |
|
It sounds like a solid idea to me but I'm not able to test at the moment to see for myself. I would recommend making an issue for it so we can get this fix merged for the next release. |
|
Both the actor's name and the character names scroll for me. Win.20230315.17.24.32.Pro.mp4 |
1hitsong
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the extras cast and crew section, it appears that some actors have empty "roles".
Changes
Instead of showing "as " when the actor's role is empty, show "Actor" instead.
Issues
Fixes #1032
alternative to #1034