SRT subtitles not displayed when "Text Subtitles Only" option is enabled

[dathbe]

Software Versions

• Jellyfin Server Version: 10.8.13
• Roku Client Version: 2.0.1 (2.0 build 1)

Describe the bug

When the "Text Subtitles Only" setting is enabled, the app hides SRT subtitles, which are text subtitles.

How To Reproduce

1. Enable "Text Subtitles Only" (Settings>Playback>Text Subtitles Only)
2. Play a movie with SRT subtitles
3. Press the up button to enter the option menu
4. SRT subtitles are not available

Expected behavior

"Text Subtitles Only" should only hide graphic subtitles (e.g., PGS)

Logs

N/A

Screenshots

Connection Information

• Is server local or remote? Local
• Is server connection HTTP or HTTPS? HTTPS

Additional context

[1hitsong]

Found the root cause. Working on a fix.

The code only allows a subtitle track to have 1 type. forced, default, text, or normal. In this case, the subtitle track is both default AND text, but only the default will get picked up.

[1hitsong]

@dathbe Please test this PR and see if it resolves your issue: #1633

[dathbe]

Confirmed that PR 1633 fixes this issue for me. Text subtitles are now shown with the "Text Subtitles Only" option enabled, even if they are set to default. Thanks!

[1hitsong]

Fixed by #1633