-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to validate XML translation files #1033
Conversation
I also looked into validating the XML files against the DTD that .ts files use but because the DTD is invalid according to the file itself "This element wildcard is no valid DTD. No better solution available." all of the apps I used to try and validate our XML files just spit out errors about the DTD file being malformed. I managed to edit the DTD file and validate the files against that but since DTD files are new to me I didn't feel confident in adding my hacked DTD file to this PR After hacking the DTD file so i could validate, all our files looked fine with the exception of so it should look like this
not this
edit: or maybe my hacked DTD file was wrong? weblate seems to commit them in the "wrong" order. I'm not sure but I'm not really worried about validating with the DTD file. I think syntax and duplicate checking would be enough. |
…-roku into add-xml-workflow
I think I'm done messing with this PR now. I have a couple more things I want to do with workflows but I'll start a new PR |
This adds a github workflow called
lint.yml
which is our old workflowvalidate.yml
copied over with a new step to validate translation files. The new step also checks for duplicate entries per file but currently doesn't throw an error when it finds them. There area buncharound 1300 between all the translation files that need to be fixed. After that, we can make the workflow throw an error to prevent manually adding a duplicate entryContext: A while back we had a translation file get malformed (missing a closing tag I believe) and that broke a lot (all?) of the translation strings for the app. This workflow should prevent that from happening again
Changes
lint.yml
validate.yml
into "brightscript" stepvalidate.yml
Issues
Fixes #708