Fix overhang on home not reshowing when returning from movie library view #1428
Conversation
| @@ -87,7 +87,7 @@ sub popScene() | |||
|
|
|||
| group.visible = false | |||
|
|
|||
| if groupType = "JFScreen" | |||
| if LCase(groupType) = "jfscreen" or LCase(groupType) = "movielibraryview" | |||
There was a problem hiding this comment.
MovieLibraryView.xml extends JFScreen and already has a OnScreenHidden() function so this code shouldn't be needed.
I can't reproduce your bug but I'm pretty sure I broke this in #1374 here. If you change the code back to isSubType() I bet it will work. I was trying to refactor because I thought they did the same thing but the functions work differently see here
There was a problem hiding this comment.
The OnScreenHidden() wasn't getting called because grouptype is "MovieLibraryView" and not "JFScreen."
It's what you said, the difference between isSubType() and .subtype()
There was a problem hiding this comment.
We should close this PR and revert those changes because they can have unentended consequences since it's not checking that the component is extending.
cewert
added
the
ignore-changelog
Changes
Calls OnScreenHidden() for movie library view.
Issues
Fixes #1427