Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Next Episode" button updates #1458

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 29, 2023

The "Next Episode" popup was being shown on all video types. This changes that so it only shows for episodes (type = 4. see here for docs), fixes some bugs, and hides the button a second before the next video is loaded.

Changes

  • Only show the "Next Episode" button when the video content is type "Episode"
  • Use opacity instead of visibility when checking the button's state
  • Show the button 1 second early to allow time for the 1sec animation
  • Hide the button when the countdown reaches 1 instead of letting the button show 0 and never removing it

A lot of code taken from #1051 so credit @1hitsong

Fixes a bug where the button was displayed for all media types i.e. Movies
Fixes a bug where the button would display negative numbers if you paused the show

@cewert cewert requested a review from a team as a code owner October 29, 2023 15:52
@cewert cewert changed the title Only show the "Next Episode" button for episodes "Next Episode" button updates Oct 29, 2023
@1hitsong 1hitsong merged commit 91d7144 into jellyfin:unstable Nov 1, 2023
9 checks passed
@cewert cewert added the bug-fix This fixes a bug. label Nov 5, 2023
@cewert cewert deleted the fix-next-episode-popup branch January 14, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants