Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rounded corner on unplayed episode count #1542

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fix rounded corner on unplayed episode count #1542

merged 1 commit into from
Nov 29, 2023

Conversation

photonconvergence
Copy link
Contributor

@photonconvergence photonconvergence commented Nov 29, 2023 •
edited
Loading

Rounds the corner of the unplayed episode count in GridItem.

Apparently MaskGroup doesn't work properly on child Rectangle unless rectangle opacity < 1

Before:
20231128_205842

After:
after2

@photonconvergence photonconvergence requested a review from a team as a code owner November 29, 2023 05:30
@1hitsong 1hitsong changed the title Fix corner on unplayed episode count Fix rounded corner on unplayed episode count Nov 29, 2023
1hitsong
1hitsong approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@1hitsong 1hitsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recreated the issue and confirmed this PR fixes it.

Nice job.

@1hitsong 1hitsong merged commit 9192dc6 into jellyfin:unstable Nov 29, 2023
9 checks passed
@cewert cewert added the general-improvement Quality of life improvements that don't add new functionality. label Nov 29, 2023
@photonconvergence photonconvergence deleted the round-unplayedcount branch November 30, 2023 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1hitsong 1hitsong 1hitsong approved these changes

Assignees
No one assigned
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Ongoing development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@photonconvergence @1hitsong @cewert