Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ListPoster crash #1859

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Fix ListPoster crash #1859

merged 1 commit into from
Jul 24, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 24, 2024

Prevent crash by validating we have access to global constants before using. Comes from roku.com crash log

Crashlog:


posterbackgrounds <uninitialized> 
m                roAssociativeArray refcnt=2 count:11 
global           Interface:ifGloba$1 Local Variables: 
   file/line: pkg:/components/ListPoster.brs(17) 
#0  Function init() As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/ListPoster.brs(17)

which points to this line after running build-prod on 2.1.1:

posterBackgrounds = m.global.constants.poster_bg_pallet

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 24, 2024
@cewert cewert requested a review from a team as a code owner July 24, 2024 14:48
@cewert cewert merged commit 1114ec1 into jellyfin:2.1.z Jul 24, 2024
13 checks passed
@cewert cewert deleted the fix-listposter-crash branch July 25, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants