Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix video player crash (2) #1868

Merged
merged 1 commit into from
Jul 25, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 25, 2024

Validate video content data is valid to prevent crash. This comes from the roku crash log.

Crashlog:

playstatetask    <uninitialized> 
params           roAssociativeArray refcnt=1 count:4 
m                roAssociativeArray refcnt=4 count:19 
global           Interface:ifGloba$1 state            String (VT_STR_CONST) val:"stop" 
Local Variables: 
   file/line: pkg:/components/video/VideoPlayerView.brs(598) 
#0  Function onstate(msg As Dynamic) As Voi$1 file/line: pkg:/components/video/VideoPlayerView.brs(615) 
#1  Function reportplayback(state As String) As Voi$1 Backtrace: 
'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/video/VideoPlayerView.brs(615)

which points to this line after running build-prod on 2.1.2:

if m.top.content.live

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 25, 2024
@cewert cewert requested a review from a team as a code owner July 25, 2024 14:03
@cewert cewert merged commit c9c0404 into jellyfin:2.1.z Jul 25, 2024
13 checks passed
@cewert cewert deleted the fix-videoplayer-crash2 branch July 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants