Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix home page crash #1870

Merged
merged 1 commit into from
Jul 28, 2024
Merged

Fix home page crash #1870

merged 1 commit into from
Jul 28, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 28, 2024

This is one of those weird roku bugs it seems since m.itemText is created during init(). Comes from roku.com crash log and is currently the worst offender:

    Type: "Video" 
} 
<Component: roAssociativeArray> = 
    IsRequired: fals$1 Condition: "EqualsAny" 
{ 
nent: roArray> 
    Type: "Audio" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: tru$1 Property: "AudioChannels" 
    Value: 6 
} 
<Component: roAssociativeArray> = 
{ 
    Codec: "mpg123" 
    Conditions: <Component: roArray> 
    Type: "VideoAudio" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: tru$1 Property: "AudioChannels" 
    Value: 2 
} 
<Component: roAssociativeArray> = 
{ 
    Codec: "mpg123" 
    Conditions: <Component: roArray> 
    Type: "Audio" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: tru$1 Property: "AudioChannels" 
    Value: 2 
} 
<Component: roAssociativeArray> = 
{ 
    Codec: "h264" 
    Conditions: <Component: roArray> 
    Type: "Video" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "NotEquals" 
    IsRequired: fals$1 Property: "IsAnamorphic" 
    Value: "true" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: fals$1 Property: "VideoBitDepth" 
    Value: "8" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "EqualsAny" 
    IsRequired: fals$1 Property: "VideoProfile" 
    Value: "high|main" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "EqualsAny" 
    IsRequired: fals$1 Property: "VideoRangeType" 
    Value: "SDR" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: fals$1 Property: "VideoLevel" 
    Value: "42" 
} 
<Component: roAssociativeArray> = 
{ 
    Condition: "LessThanEqual" 
    IsRequired: tru$1 Property: "VideoBitrate" 
    Value: "10000000" 
} 
<Component: roAssociativeArray> = 
{ 
    Codec: "av1" 
    Conditions: <Component: roArray> 
Invalid value for left-side of expression. (runtime error &he4) in pkg:/components/home/HomeItem.brs(43) 
Backtrace: 
#0  Function itemcontentchanged() As Voi$1 file/line: pkg:/components/home/HomeItem.brs(44) 
Local Variables: 
global           Interface:ifGloba$1 m                roAssociativeArray refcnt=2 count:2 
itemdata         roSGNode:HomeData refcnt=1 
localglobal      roSGNode:Node refcnt=2 
playedindicatorleftposition <uninitialized> 
extraprefix      <uninitialized> 
textextra        <uninitialized>

which points to this line after running build-prod on 2.0.7:

m.itemText.maxWidth = itemData.imageWidth

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 28, 2024
@cewert cewert requested a review from a team as a code owner July 28, 2024 00:22
@cewert cewert merged commit b748dd4 into jellyfin:2.1.z Jul 28, 2024
13 checks passed
@cewert cewert deleted the fix-homeitem-crash branch July 28, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants