Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on episode list #1889

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

cewert
Copy link
Member

@cewert cewert commented Jul 31, 2024

Prevent crash by validating all data sent to CreateSeasonDetailsGroupByID(). Comes from roku.com crash log:

group            <uninitialized> 
seasonmetadata   <uninitialized> 
m                roAssociativeArray refcnt=3 count:6 
global           Interface:ifGloba$1 seasonid         Invali$1 seriesid         roString (2.1 was String) refcnt=1 val:"9f3800b10bae7a29a8bfbfc6d5b4f32e" 
Local Variables: 
   file/line: pkg:/source/Main.brs(786) 
#0  Function main(args As Dynamic) As Voi$1 file/line: pkg:/source/ShowScenes.brs(793) 
#1  Function createseasondetailsgroupbyid(seriesid As String, seasonid As String) As Dynami$1 Backtrace: 
Type Mismatch. Unable to cast "Invalid" to "String". (runtime error &h18) in pkg:/source/ShowScenes.brs(791)

which points to this line after running build-prod on 2.1.2:

function CreateSeasonDetailsGroupByID(seriesID as string, seasonID as string) as dynamic

Issues

Ref #1164

@cewert cewert added the bug-fix This fixes a bug. label Jul 31, 2024
@cewert cewert requested a review from a team as a code owner July 31, 2024 13:25
@cewert cewert merged commit 3b13fab into jellyfin:2.1.z Jul 31, 2024
13 checks passed
@cewert cewert deleted the fix-season-details-crash branch October 4, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants