Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play Song as Part of a Playlist #1895

Merged
merged 1 commit into from
Aug 4, 2024

Conversation

michaelcresswell
Copy link

Changes

When user clicks on a song, queue the playlist and start playback at requested song.

Based on #1644

Issues

#1894

@michaelcresswell michaelcresswell requested a review from a team as a code owner August 2, 2024 19:32
@michaelcresswell
Copy link
Author

There are a few other instances of a single song being queued from what may be a list but I'm not sure where they're called from so I hesitate to change to either.

https://github.com/jellyfin/jellyfin-roku/blob/master/source/Main.bs#L393

https://github.com/jellyfin/jellyfin-roku/blob/master/source/Main.bs#L559

@cewert
Copy link
Member

cewert commented Aug 3, 2024

Line 393 is when a single audio file is selected from the home screen. I know the favorites row supports single songs but I'm not sure if there are more rows with support as well

Line 559 is from the search results

@cewert cewert added the new-feature A new feature that currently doesn't exist. label Aug 3, 2024
@cewert
Copy link
Member

cewert commented Aug 3, 2024

One idea for the single songs would be to open the album the song comes from (do all songs in jellyfin have an album?) with the single song selected. That way the user could learn about the album before choosing to play it which would then play the whole album. Or you could just assume the user wants to listen to the album and queue the whole album but IMO that would make more sense for quickplay (the play button).

@michaelcresswell
Copy link
Author

The enhancements make sense but they sound more involved than queueing up the rest of a list so I think they should be separate tasks. Especially while I’m just getting started with the codebase.

@cewert
Copy link
Member

cewert commented Aug 3, 2024

The enhancements make sense but they sound more involved than queueing up the rest of a list so I think they should be separate tasks. Especially while I’m just getting started with the codebase.

Of course! I didn't mean to imply you needed to change anything :)

@cewert cewert added general-improvement Quality of life improvements that don't add new functionality. and removed new-feature A new feature that currently doesn't exist. labels Aug 4, 2024
@cewert cewert merged commit 103f01c into jellyfin:master Aug 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general-improvement Quality of life improvements that don't add new functionality.
Projects
Development

Successfully merging this pull request may close these issues.

2 participants