Fix AAC codec support for real. Transcode Main
and HE-AAC
#1963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1928 correctly tells the server we can't play profile Main but the server is still sending us the same audio stream. This PR actually fixes the problem by forcing AAC profile Main as well as HE-AACv1 to transcode to MP3 since the server doesn't currently support transcoding from one AAC profile to another.
I also added another global session var
video
to hold the meta data for the currently playing videoChanges
m.global.session.video
HE-AAC
to the list of AAC profiles we don't support (comes from roku docs)Issues
Ref #1928