Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix AAC codec support for real. Transcode Main and HE-AAC #1963

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

cewert
Copy link
Member

@cewert cewert commented Oct 4, 2024

#1928 correctly tells the server we can't play profile Main but the server is still sending us the same audio stream. This PR actually fixes the problem by forcing AAC profile Main as well as HE-AACv1 to transcode to MP3 since the server doesn't currently support transcoding from one AAC profile to another.

I also added another global session var video to hold the meta data for the currently playing video

Changes

  • Add new global var m.global.session.video
  • Use new video var to force AAC profiles we don't support to be transcoded
  • Adds HE-AAC to the list of AAC profiles we don't support (comes from roku docs)

Issues

Ref #1928

@cewert cewert added the bug-fix This fixes a bug. label Oct 4, 2024
@cewert cewert requested a review from a team as a code owner October 4, 2024 01:35
@cewert
Copy link
Member Author

cewert commented Oct 4, 2024

Testing

  • AAC profile Main ffmpeg -i video.mkv -c:a aac -profile:a aac_main aac-main.mkv
  • AAC profile HE-AAC ffmpeg -i video.mkv -c:a libfdk_aac -profile:a aac_he -b:a 32k he-aac.mkv
    • Need to compile ffmpeg yourself to use libfdk_aac encoder. Ubuntu docs here

AAC LC and HE-AACv2 are more common and I was able to use examples from my library

@cewert cewert merged commit 8942292 into jellyfin:2.1.z Oct 4, 2024
11 checks passed
@cewert cewert deleted the fix-aac-support branch October 4, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants