Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ItemGrid (Movies) #227

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Conversation

neilsb
Copy link
Member

@neilsb neilsb commented Jun 11, 2020

Update to styling and behaviour of Item Grid (for Movies):

dev

Changes

Idea behind 'JFContent' item is that it will have a common set of properties across all content types, allowing other reusable Components to display any content item without worrying about type. (Can replace HomeItem later)

This adds a new ItemGrid2 component and is used to Display Movies. Can replace existing ItemGrid and allow displaying of other content (TV Series, Photos, Music Albums, etc)

Only Movies were edited to try and keep size of PR small to air review. Enabling for other content types should be straightforward.

Copy link
Member

@anthonylavado anthonylavado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me on my device!

One concern which we can address later if you wish, which is that if an item doesn't have a backdrop, it stays on the previously shown backdrop. I don't know if we want to keep that or change to a default background instead.

@neilsb
Copy link
Member Author

neilsb commented Jun 16, 2020

if an item doesn't have a backdrop, it stays on the previously shown backdrop. I don't know if we want to keep that or change to a default background instead.

Yeah, I wasn't sure. It was a conscious decision to leave it on the last shown one, rather than have it revert to a black background, but I'm happy for it to work either way.

And when we get the user settings screen sorted there will be an option to disable the backdrops while browsing.

@anthonylavado
Copy link
Member

I'm okay with leaving it on the last shown one. Most things should have backdrops, and I think the black would be too jarring.

@anthonylavado anthonylavado merged commit 2fefdc4 into jellyfin:master Jun 16, 2020
@neilsb neilsb deleted the updated-itemgrid branch October 28, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants