update LiveTV to use ItemGrid2 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neilsb
reviewed
Oct 18, 2020
|
Looks great. The hard work done to move LiveTV into the new grid. Thanks :) Should be straightforward enough to get it to show the channel images once this is merged, although given the non-standard image sizes of the channel logos I actually think it may well look better as is, just displaying the channel name as text. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We have a gorgeous new ItemGrid2 being used by TV shows and Movies and Collections... Now also including Live TV channels. (Noticeably less impressive because my TV channels don't have images, but it moves this onto the common infrastructure with infinite scroll, etc).
Issues