Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto play the next TV episode #317

Merged
merged 2 commits into from
Dec 2, 2020
Merged

Auto play the next TV episode #317

merged 2 commits into from
Dec 2, 2020

Conversation

cewert
Copy link
Member

@cewert cewert commented Nov 30, 2020

This auto plays the next available episode for all videos of type "Episode". Ideally this would be a client user setting but user settings still need a lot of work.

Changes
Add showID field to JFVideo
Small refactor to StopPlayback()
Create playNextEpisode() function to lookup and play the next available episode
Fix a typo that was preventing the video title from being passed to the video player

Issues
Fixes #160

@neilsb
Copy link
Member

neilsb commented Nov 30, 2020

Just had a quick play, and look good against 10.6. However, against unstable (10.7) the API call in playNextEpisode() seems to be returning invalid.

@Artiume
Copy link
Contributor

Artiume commented Nov 30, 2020

sweet and simple, love it. Works for me on 10.6

@cewert
Copy link
Member Author

cewert commented Nov 30, 2020

@neilsb My server is on latest stable so I'm unable to test it. Does the server log show anything when the API call fails?

The API call I'm using may not be the best way to to pull the next episode so I'm open to suggestions

@neilsb
Copy link
Member

neilsb commented Nov 30, 2020

@neilsb My server is on latest stable so I'm unable to test it. Does the server log show anything when the API call fails?

It seems to be returning a valid response, just with no episodes. Dropping the StartItemId seems to return data - so not sure what's going on. I'll try to have a more in detail look tomorrow. Apparently there is a "unstable" demo server at https://demo.jellyfin.org/unstable

@neilsb
Copy link
Member

neilsb commented Dec 1, 2020

Problem is on the server side due to a change in how it compares Guids. One of the server team is looking at it, so that should allow this to work fine

@Artiume
Copy link
Contributor

Artiume commented Dec 2, 2020

Should we add in Neil's countdown marker to this PR?

@neilsb
Copy link
Member

neilsb commented Dec 2, 2020

Should we add in Neil's countdown marker to this PR?

Since it can be dropped on top, I'd say we just merge this one and can raise another one for teh countdown marker thing

@cewert cewert merged commit d165eee into jellyfin:master Dec 2, 2020
@cewert cewert deleted the autoplay-episodes branch December 6, 2020 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically play next episode
3 participants