Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent Login Screens hiding main Scene #498

Merged
merged 2 commits into from
Nov 15, 2021

Conversation

neilsb
Copy link
Member

@neilsb neilsb commented Nov 14, 2021

New Scene Manager implemented in #492 now handles the visibility of screens in the screen stack, and individual screens should not be showing/hiding screens themselves.

The login screens were still doing then when the user was selected and when back was pressed, resulting in the login process showing blank screens.

Changes

  • Prevent login screens from hiding themselves and leave to Scene Manager

Copy link
Contributor

@jdlayman jdlayman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Sorry I should have caught that when I worked Scene Manager!

@neilsb
Copy link
Member Author

neilsb commented Nov 15, 2021

Looks good to me. Sorry I should have caught that when I worked Scene Manager!

Not a problem. I missed it too, and have been missing it since that was merged until this weekend :)

@anthonylavado anthonylavado merged commit d5c3165 into jellyfin:master Nov 15, 2021
@neilsb neilsb deleted the login-screen-visiblity branch January 16, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants