-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add h265/hevc to deviceCapabilities.tsVideoCodecs #543
Conversation
relevant: |
edit: subtitle issue is happening here: https://github.com/jellyfin/jellyfin/blob/e778877f558bee526b3b4a952e19bebcf560f464/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs#L58 edit: this was just an issue with the subtitle profiles. |
"IsRequired": false | ||
} | ||
] | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These lines were removed because they appear in testing to cause containers with two AAC streams to transcode.
Feedback from dmitry lyzo supports this.
—
Yesterday at 6:55 PM
As I understand this: device supports AAC in a video or audio file if it is not a secondary track.
Ahh, IsSecondaryAudio: false means client can only use the default or the first track
otherwise they are encoded into directstreams
probably, ALL text subtitles should be added with "external" as long as they comply with https://developer.roku.com/en-ca/docs/developer-program/media-playback/closed-caption.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all seems to work and certainly resolved the hevc issue.
fixes #513
we need to expose a setting or something for this, ultimately, so users can decide whether or not to utilize their server-side tonemapping, if its available to them.