Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add h265/hevc to deviceCapabilities.tsVideoCodecs #543

Merged
merged 4 commits into from
Mar 30, 2022

Conversation

whiteowl3
Copy link
Contributor

fixes #513
we need to expose a setting or something for this, ultimately, so users can decide whether or not to utilize their server-side tonemapping, if its available to them.

@whiteowl3
Copy link
Contributor Author

relevant:
jellyfin/jellyfin#7199

@whiteowl3
Copy link
Contributor Author

whiteowl3 commented Mar 29, 2022

actually there is still a subtitle selection issue floating around on titles which my changes cause to directstream instead of transcode on the roku.
I lack the hardware to isolate this tho. if somebody has a roku attached to a dd+ capable device, it would be great to know if you can select subtitles during playback of an HEVC-HDR DD+ 5.1 video file, and if it correctly directplays with these changes.

edit: subtitle issue is happening here: https://github.com/jellyfin/jellyfin/blob/e778877f558bee526b3b4a952e19bebcf560f464/MediaBrowser.MediaEncoding/Subtitles/SubtitleEncoder.cs#L58

edit: this was just an issue with the subtitle profiles.

"IsRequired": false
}
]
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These lines were removed because they appear in testing to cause containers with two AAC streams to transcode.
Feedback from dmitry lyzo supports this.

 — 
Yesterday at 6:55 PM
As I understand this: device supports AAC in a video or audio file if it is not a secondary track.
Ahh, IsSecondaryAudio: false means client can only use the default or the first track

otherwise they are encoded into directstreams
@whiteowl3
Copy link
Contributor Author

probably, ALL text subtitles should be added with "external" as long as they comply with https://developer.roku.com/en-ca/docs/developer-program/media-playback/closed-caption.md
(I have no idea which ones do or do not)

Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all seems to work and certainly resolved the hevc issue.

@neilsb neilsb enabled auto-merge March 30, 2022 20:17
@neilsb neilsb disabled auto-merge March 30, 2022 20:17
@neilsb neilsb merged commit 5bf3a68 into jellyfin:master Mar 30, 2022
@whiteowl3 whiteowl3 deleted the patch-1 branch March 30, 2022 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio Transcode Issues
2 participants