Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support strms #548

Merged
merged 9 commits into from
Apr 26, 2022
Merged

Support strms #548

merged 9 commits into from
Apr 26, 2022

Conversation

whiteowl3
Copy link
Contributor

@whiteowl3 whiteowl3 commented Apr 1, 2022

basic prototype for using strms
fixes #549

@whiteowl3 whiteowl3 changed the title Update VideoPlayer.brs basic prototype for playing strms Apr 1, 2022
@whiteowl3 whiteowl3 changed the title basic prototype for playing strms play strms Apr 8, 2022
@whiteowl3
Copy link
Contributor Author

@neilsb if you would kindly confirm or deny your interest in this functionality I will (or will not) try to set up a test server for you. I understand testing remote mtls streams is probably more annoying than your average PR.

@neilsb
Copy link
Member

neilsb commented Apr 19, 2022

I'm more than happy for it to be added. It's something I was intending to try and understand how works at the weekend there, but didn't have the time. I'll try to get to it this week. Sorry for the delay.

source/VideoPlayer.brs Outdated Show resolved Hide resolved
@whiteowl3
Copy link
Contributor Author

i was not able to fully test these final changes on my infrastructure, just as a heads up.

@neilsb
Copy link
Member

neilsb commented Apr 23, 2022

i was not able to fully test these final changes on my infrastructure, just as a heads up.

What is it you've been unable to test? I've been able to able to test strm hosted on localhost and external URL, and it appears to work OK.

source/VideoPlayer.brs Outdated Show resolved Hide resolved
@whiteowl3
Copy link
Contributor Author

i was not able to fully test these final changes on my infrastructure, just as a heads up.

What is it you've been unable to test? I've been able to able to test strm hosted on localhost and external URL, and it appears to work OK.

just that. my infrastructure has all the mtls stuff, so i can test all the functionality up until the final gutting of those extra parts and bsfmt-ing.

@neilsb
Copy link
Member

neilsb commented Apr 24, 2022

So this seems OK now. If you're happy with how the get_url() interaction works I am good to approve and merge?

@whiteowl3
Copy link
Contributor Author

So this seems OK now. If you're happy with how the get_url() interaction works I am good to approve and merge?

Im still stuck on lines 138 and 139. Do they not need to be moved out of the if block?

@whiteowl3
Copy link
Contributor Author

actually i think its just audiotrack selection that needs to be brought out.

@whiteowl3
Copy link
Contributor Author

pretty sure its supposed to be like this. i haven't tested this modification at all though because im not at home. ill test this evening if you dont beat me to it.

@whiteowl3
Copy link
Contributor Author

@neilsb ok I'm happy when you're happy.

@neilsb neilsb changed the title play strms Support strms Apr 25, 2022
Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems to work.

@neilsb neilsb merged commit be1d4a5 into jellyfin:master Apr 26, 2022
@whiteowl3 whiteowl3 deleted the patch-1 branch April 26, 2022 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

play strms
2 participants