-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support strms #548
Support strms #548
Conversation
@neilsb if you would kindly confirm or deny your interest in this functionality I will (or will not) try to set up a test server for you. I understand testing remote mtls streams is probably more annoying than your average PR. |
I'm more than happy for it to be added. It's something I was intending to try and understand how works at the weekend there, but didn't have the time. I'll try to get to it this week. Sorry for the delay. |
i was not able to fully test these final changes on my infrastructure, just as a heads up. |
What is it you've been unable to test? I've been able to able to test strm hosted on localhost and external URL, and it appears to work OK. |
just that. my infrastructure has all the mtls stuff, so i can test all the functionality up until the final gutting of those extra parts and bsfmt-ing. |
So this seems OK now. If you're happy with how the |
Im still stuck on lines 138 and 139. Do they not need to be moved out of the if block? |
actually i think its just audiotrack selection that needs to be brought out. |
pretty sure its supposed to be like this. i haven't tested this modification at all though because im not at home. ill test this evening if you dont beat me to it. |
@neilsb ok I'm happy when you're happy. |
basic prototype for using strms
correct wrongness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All seems to work.
basic prototype for using strms
fixes #549