Add Series, Season and episode navigation #557
Conversation
Fixed the "Watched" option as it was not showing up on the home screen when selecting an episode Add "Go to Series" from the "Continue Watching row" when selecting an episode Add "Go to Season" from the "Continue Watching row" when selecting an episode Add "Go to Episode" from the "Continue Watching row" when selecting an episode ( This takes the user to the specific episode in a movie scene layout since we do not have a specific episode scene yet.
Commit out the Title as this was causing the app to crash when coming from the home screen episode navigation
|
The title appears to work for me with 1.4.12. However it does crash with the Updated-Episode-Nav branch. I'm wondering if there is something slightly off with the way you're querying the server for the series / season info? |
neilsb
changed the title
source/VideoPlayer.brs
Outdated
| else | ||
| return option_dialog(["Resume playing at " + ticksToHuman(time) + ".", "Start over from the beginning."]) | ||
| return option_dialog(["Resume playing at " + ticksToHuman(time) + ".", "Start over from the beginning.", "Watched", "Go to series", "Go to season", "Go to episode"]) |
There was a problem hiding this comment.
I think "Watched" has been added to this list by mistake. Also, we don't want these new items shown when the popup appears anywhere else other than the home screen.
The same popup is used when:
- a part-watched episode is selected from the Episode List (Go into a TV Show, then select a season, then select a part-played episode).
- a part-played movie is played from the movie detail screen
There was a problem hiding this comment.
I believe "watched" will set the episode to "watched". Meaning if it didn't report correctly to the server you can reset it as watched.
There was a problem hiding this comment.
It's just that when viewing a partially viewed movie, you get the Menu Option related to TV Series (which don't make sense) and I don't think the watched item should appear in this list here, since movies have a button to toggle the watched status on this screen already.
@jimdogx Looks like this is working now. The removal of the 2 lines setting the overhang title appears to be a better user experience. In the current client, when selecting a TV Show or Season, it looks like the title is set once, then quickly overwritten. This looks to have fixed that too. |
|
Thank you for all the feedback and suggestions!
I'm still learning as we go!
…On Sun, Apr 24, 2022, 11:51 AM Neil Burrows ***@***.***> wrote:
The title appears to work for me with 1.4.12. However it does crash with
the Updated-Episode-Nav branch. I'm wondering if there is something
slightly off with the way you're querying the server for the series /
season info?
@jimdogx <https://github.com/jimdogx> Looks like this is working now. The
removal of the 2 lines setting the overhang title appears to be a better
user experience. In the current client, when selecting a TV Show or Season,
it looks like the title is set once, then quickly overwritten. This looks
to have fixed that too.
—
Reply to this email directly, view it on GitHub
<#557 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT6PDRAIIEEITSAK2FBP4PLVGV3YHANCNFSM5TAKMAHQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
neilsb
changed the title
Aggreed Co-authored-by: Neil Burrows <neil@pawprint.co.uk>
Aggreed Co-authored-by: Neil Burrows <neil@pawprint.co.uk>
Agreed Co-authored-by: Neil Burrows <neil@pawprint.co.uk>
|
This has been updated to only show the extra options for Episodes/Series on "Continue Watching" |
My server issues have been resolved, but I probably won't get to test anything until tomorrow evening (my time) at the earliest. |
|
Looks to be working, not seeing any crashes. 👍 |
|
I'm not sure if this is the place or if a separate ticket would be better, but I have noticed an issue with the new menu which appears which choosing an item from the "continue watching" list. If the "watched" option is chosen, nothing appears to happen; the thumbnail is still there. Selecting it again does not produce the menu again, it just plays from the start. I think the episode is being marked as watched, there's just no UI update so it's a confusing experience.. If I choose "watched" then exit the app and reopen, the item is gone from "continue watching". |
Fixed the "Watched" option as it was not showing up on the home screen when selecting an episode
Add "Go to Series" from the "Continue Watching row" when selecting an episode
Add "Go to Season" from the "Continue Watching row" when selecting an episode
Add "Go to Episode" from the "Continue Watching row" when selecting an episode ( This takes the user to the specific episode in a movie scene layout since we do not have a specific episode scene yet.
Commit out the Title as this was causing the app to crash when coming from the home screen episode navigation