Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled all titles to show under poster images #570

Merged
merged 7 commits into from
May 14, 2022

Conversation

candry7731
Copy link
Contributor

#365 - Enable Titles to show when grid is loaded instead of on focus...

Changes
Set scrolling label to visible

@neilsb
Copy link
Member

neilsb commented Apr 24, 2022

This looks good, but I'd like to hold off this until we get the client side setting place, so a user can choose to switch whether to have them on or off in the preferences.

I'll make a concerted effort to get that in place this week (sorry for the delay), and it'll be a trivial change to check that in this PR.

@neilsb
Copy link
Member

neilsb commented May 2, 2022

I've hooked up a user setting for this, now the settings screen is in place.

I've had a play with your changes, and have a couple of things for discussion regarding long titles

  • Item titles are currently Scrolling Labels. When they're are always displayed, do we want them always scrolling, or should they only scroll when the item is highlighted?
  • When you've got a couple of items with long titles together, the titles now run into each other (especially if scrolling). I think it may be good to do something to address this.

image

@neilsb neilsb linked an issue May 4, 2022 that may be closed by this pull request
@candry7731
Copy link
Contributor Author

I've hooked up a user setting for this, now the settings screen is in place.

I've had a play with your changes, and have a couple of things for discussion regarding long titles

  • Item titles are currently Scrolling Labels. When they're are always displayed, do we want them always scrolling, or should they only scroll when the item is highlighted? I set this to only scroll when item has focus. I think this works better
  • When you've got a couple of items with long titles together, the titles now run into each other (especially if scrolling). I think it may be good to do something to address this. I updated the text width to be smaller and this this gives more padding left and right

image

@neilsb neilsb merged commit e14bd09 into jellyfin:master May 14, 2022
Fyb3roptik pushed a commit to Fyb3roptik/jellyfin-roku that referenced this pull request Jun 6, 2022
@candry7731
Copy link
Contributor Author

candry7731 commented Oct 11, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to display video titles always instead of when highlighted
2 participants