Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watched/Favorite text #594

Merged
merged 6 commits into from
May 11, 2022
Merged

Watched/Favorite text #594

merged 6 commits into from
May 11, 2022

Conversation

candry7731
Copy link
Contributor

Updated the "watched" and "favorite" button text to update when the buttons have been selected

Added "Set Favorite" and "Set Watched" when the content is not favorited and/or watched
Added "Favorite" and "Watched" when the content has been favorited and/or watched

Issues
This should resolve #368

@candry7731 candry7731 changed the title Watched/Favorit text #368 Watched/Favorite text #368 May 11, 2022
@candry7731 candry7731 changed the title Watched/Favorite text #368 Watched/Favorite text May 11, 2022
Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new text ("Set Favorite" and "Set Wartches") need to be added to the default translation file locale\en_US\translations.ts

components/movies/MovieDetails.brs Outdated Show resolved Hide resolved
@neilsb neilsb merged commit 12f8f18 into jellyfin:master May 11, 2022
Fyb3roptik pushed a commit to Fyb3roptik/jellyfin-roku that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display the watched status using more intuitive text
2 participants