Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preroll video support #644

Merged
merged 5 commits into from
Jul 9, 2022
Merged

Add preroll video support #644

merged 5 commits into from
Jul 9, 2022

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Jun 9, 2022

Changes
Added functionality to check if preroll videos are enabled and available. If so, they will play before any video, matching the functionality of the web client.

Issues
Fixes #448 #448

@neilsb
Copy link
Member

neilsb commented Jun 21, 2022

On the server, while pre-rolls need to be enabled at the server level via the Plug-in, each user has an option whether to play them or not via the User Settings -> Playback -> Cinema Mode option. We should probably do similar on this client to prevent pre-rolls being forced on the user by a server admin. We can either use the web "Cinema Mode" option, or add our own User Setting to give similar control on the Roku.

When selecting a partially watched item, the Preroll plays before giving the user the popup menu of Continue / Restart. Would probably be better to show this menu first (Especially now there are options to mark watched, go to season, go to episode etc).

On web, if you're select a partially watched item them the preroll doesn't play at all. Might be worth implementing that too?

@1hitsong
Copy link
Member Author

add our own User Setting to give similar control on the Roku.

I love this idea! Let's go this route.

When selecting a partially watched item, the Preroll plays before giving the user the popup menu of Continue / Restart. Would probably be better to show this menu first (Especially now there are options to mark watched, go to season, go to episode etc).

On web, if you're select a partially watched item them the preroll doesn't play at all. Might be worth implementing that too?

100%! I'll work on this as well.

@1hitsong
Copy link
Member Author

1hitsong commented Jul 1, 2022

@neilsb Updates made

Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it almost perfects now. The last thing that I just noticed is that when Automatically play next episode is selected, the preroll plays between every episode. I'd suggest it's only wanted at the start of the first episode?

locale/en_US/translations.ts Outdated Show resolved Hide resolved
@1hitsong
Copy link
Member Author

1hitsong commented Jul 4, 2022

@neilsb Setting content updated. Added code to prevent intros before auto-played next episodes.

Copy link
Member

@neilsb neilsb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good.

@neilsb neilsb merged commit f5412fd into jellyfin:master Jul 9, 2022
@1hitsong 1hitsong deleted the add-preroll-support branch July 18, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin intros not requested
2 participants