-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Artist view UI and UX improvement #704
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks awesome!! |
I'm getting an error when trying to view an album, I hope that helps. Let me know if you need any other info.
|
@candry7731 Try it now. |
chore(deps): pin vimtor/action-zip action to 5f1c4aa
Add song track number and length to album view
Fix crash when playing single song
jimdogx
reviewed
Aug 6, 2022
jimdogx
approved these changes
Aug 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Improvements to the UI and UX of the music artist view. The albums are now presented in a grid instead of a single row, making it easier to get to albums in fewer keypresses and seeing more on the screen at once.
This change also gives us room for new functionality in the future.
This PR includes a new component, Icon Button. Instead of text, it uses an icon as the primary button content and centers the text below the button.
There are 2 new functions:
Initial View
Album Grid