Jf video stats

[jimdogx]

Currently you can hit "down" for subtitles during playback. This PR adds "streaming information" if the user presses "up" during playback:

Changes
Listens for "up" press during playback and shows any streaming / transcoding information available.

Issues
This is currently using the "built in" options dialog even though these are not options. The presentation does have a side benefit of highlighting individual pieces of information as the users scrolls through the list. A custom view can be created at a later dated if deemed necessary.

[alanazar]

I've tested it and it works. Great idea for stats!

[alanazar]

The number values after "Total Bitrate: " and "Audio Codec: " have extra spaces
Answer from 1hitsong "Roku does odd auto-aligning when dealing with numbers. Likely needs to have a left align put on the value fields."
I don't know how to do that :D

[alanazar]

Tested it again and looks good
Worth revisiting later to find a way to not have Mbps or Kbps as an integer (I'll happily research this later)
Also, the left alignment of number values if that's possible.
It's a great feature to add, thanks for this!

[neilsb]

Looks good - only one issue I found (purely by chance) is that if you have the Video Stats dialog open, and the Skip Intro button appears then the Stats Dialog loses focus, and you can't get it back.

The video stats is now stuck on the screen until you exit the app with the home button (can't even exit app by pressing back).

[alanazar]

Looks good - only one issue I found (purely by chance) is that if you have the Video Stats dialog open, and the Skip Intro button appears then the Stats Dialog loses focus, and you can't get it back.

The video stats is now stuck on the screen until you exit the app with the home button (can't even exit app by pressing back).

Oh good catch! I'll keep it in mind for future testing as well

[jimdogx]

Looks good - only one issue I found (purely by chance) is that if you have the Video Stats dialog open, and the Skip Intro button appears then the Stats Dialog loses focus, and you can't get it back.

The video stats is now stuck on the screen until you exit the app with the home button (can't even exit app by pressing back).

Nice catch. I don't have that plugin installed, but will try to install it soon and re-test 👍

[1hitsong]

To piggyback off Neil, if the Skip Into button is already shown when you press up, everything works nicely until the Skip Intro button fades out. That fade out sets the focus back to the video, not the popup. Then it's stuck on screen.

[1hitsong]

FYI, Intro Skipper plugin support has been removed. With that out of the way, were there any other lingering issues?

[jimdogx]

I don't think so, but I'd wait until @neilsb chimes in to be sure 👍

[neilsb]

Nope, was all good as I recall. Just would want to test it with the rolled back PR but if someone has given it the one over since then then that's cool. I can have a look at it later on today.

[alanazar]

Last update broke the functionality.
On some videos i get a window.
On others nothing happens but then no other button works (back, play, forward, etc). I need to exit to Roku's home to then be able to access the server.

Is the bitrate what the video is reporting and not the live network traffic? If so, I suggest to revert the changes since it was working before and the missing stats were just codec dependent

[jimdogx]

BitRate turned out to be an Integer, even though I could have sworn I looked at the server code and it said it was a String. I've updated and pushed a fix (and was able to actually test it this time instead of pushing blindly) 😄

[jimdogx]

Converting PR to a draft so I can add more data to be shown....

[jimdogx]

I've added more info, I think this should be good enough for the first release of this feature:

If the user scrolls:

[alanazar]

Tested and it works great :)
(Again, really like having this feature, thanks!)

[neilsb]

Looks good, and works well.

Not sure if this is an issue or how it should work, but if you have the stream details up when the video ends, the next action (e.g. return to the details screen, autoplay next episode, etc) will not happen until the popup is closed. I am not sure what the expected behaviour would be for a normal user.

[jimdogx]

Looks good, and works well.

Not sure if this is an issue or how it should work, but if you have the stream details up when the video ends, the next action (e.g. return to the details screen, autoplay next episode, etc) will not happen until the popup is closed. I am not sure what the expected behaviour would be for a normal user.

I think this is acceptable. You can't move on until you close the popup. Otherwise, we'd have to implement some special logic for the popup to "refresh" with the next video playing etc.

[1hitsong]

To be merged 9/23 unless an issue arises.