-
-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add appears on music artist section #811
Conversation
I got a crash for a specific artist. This artist doesn't have an "Album" or "Appears On" even though if I click on the Play button it proceeds to play 8 tracks (my guess is from an album). This is a remote server so I'm going to see if I can get the folder structure for this artist from the server owner.
|
@jimdogx I added an additional check in the case no albums and no appears on items are found. I also put back a check for if there is no album data and no appears on data to fall back into an album of songs view. What actions did you take to throw the error? |
Getting a different crash now. I'd wait on additional changes until I can find out what the structure is. Also, does Album view work for you? It looks like not matter how I filter the view, it's always Artist. |
Album view issue resolved. It should work now. |
Album vs Artist view now works. It was really slow to load rows 10-20 (spinner ran forever), both on a remote server and a local server. But once it was working it was fine. Guessing some sort of metadata being built up? |
Was it slow under both views or just one? |
Turns out it was most likely the server. |
To be merged 10/7 unless an issue arises. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it on Roku, worked ok
Changes
Issues
#802