Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add appears on music artist section #811

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Add appears on music artist section #811

merged 2 commits into from
Oct 7, 2022

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Oct 1, 2022

Changes

  1. Changes music API calls to match web ui.
  2. Adds Appears On section to artist page.

Issues
#802

@1hitsong 1hitsong changed the title Add appears on artist section Add appears on music artist section Oct 1, 2022
@jimdogx
Copy link
Contributor

jimdogx commented Oct 1, 2022

I got a crash for a specific artist. This artist doesn't have an "Album" or "Appears On" even though if I click on the Play button it proceeds to play 8 tracks (my guess is from an album). This is a remote server so I'm going to see if I can get the folder structure for this artist from the server owner.

008:      if m.top.hasFocus()
009:*         m.top.getChild(m.top.selected).setFocus(true)
010:          m.top.focusButton = m.top.selected
011:      end if
012:  end sub
Source Digest(s): 
pkg: dev 1.5.0 9d21af0a Jellyfin

'Dot' Operator attempted with invalid BrightScript Component or interface reference. (runtime error &hec) in pkg:/components/roku_modules/bgv/ButtonGroupVert.brs(9)
Backtrace:
#0  Function bgv_onfocuschanged() As Void
   file/line: pkg:/components/roku_modules/bgv/ButtonGroupVert.brs(9)
Local Variables:

global           Interface:ifGlobal
m                roAssociativeArray refcnt=2 count:2
Threads:
ID    Location                                Source Code
 0    pkg:/source/Main.brs(83)                msg = wait(0, m.port)

 1*   ...dules/bgv/ButtonGroupVert.brs(9)     m.top.getChild(m.top.selected).setFocus(true)
  *selected

@1hitsong
Copy link
Member Author

1hitsong commented Oct 2, 2022

@jimdogx I added an additional check in the case no albums and no appears on items are found. I also put back a check for if there is no album data and no appears on data to fall back into an album of songs view.

What actions did you take to throw the error?

@jimdogx
Copy link
Contributor

jimdogx commented Oct 2, 2022

Getting a different crash now. I'd wait on additional changes until I can find out what the structure is.

Also, does Album view work for you? It looks like not matter how I filter the view, it's always Artist.

@1hitsong
Copy link
Member Author

1hitsong commented Oct 2, 2022

Album view issue resolved. It should work now.

@jimdogx
Copy link
Contributor

jimdogx commented Oct 3, 2022

Album vs Artist view now works. It was really slow to load rows 10-20 (spinner ran forever), both on a remote server and a local server. But once it was working it was fine. Guessing some sort of metadata being built up?

@1hitsong
Copy link
Member Author

1hitsong commented Oct 3, 2022

Was it slow under both views or just one?

@jimdogx
Copy link
Contributor

jimdogx commented Oct 6, 2022

Was it slow under both views or just one?

Turns out it was most likely the server.

@1hitsong
Copy link
Member Author

1hitsong commented Oct 6, 2022

To be merged 10/7 unless an issue arises.

Copy link
Contributor

@alanazar alanazar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it on Roku, worked ok

@1hitsong 1hitsong merged commit b5293c5 into jellyfin:unstable Oct 7, 2022
@1hitsong 1hitsong deleted the music-appears-on branch October 7, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants