loading spinner, Progress Dialog and movie details button animate

[candry7731]

Added loading spinner to movies detail screens

Added loading spinner to the movie details screen

Added progress dialog when user clicks the play button for movies and trailers

Updated movie details buttons to be hidden until all data is loaded

Updated critic rating star to be hidden until all data is loaded

[jimdogx]

I noticed that when I hit Play Movie, I get the new "Loading Movie" spinner, that goes away and then I get the regular spinner (not text). Not sure if that was the desired behavior?

[whiteowl3]

If the server holding the strm fails to respond, the spinner locks us out forever. back or instant replay should cancel the loading job and clear the spinner.
Why it is so visually different from all the other spinners?

[whiteowl3]

I noticed that when I hit Play Movie, I get the new "Loading Movie" spinner, that goes away and then I get the regular spinner (not text). Not sure if that was the desired behavior?

The first spinner is to lock out additional inputs (esp play inputs) until jellyfin responds with the stream. if the media is remote, this can take a second. so, the first spinner drops as soon as jellyfin says "here it is" and the second spinner waits until we have enough buffered to play. we need both.

[github-actions]

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

[candry7731]

This should be good to go unless anyone else finds any bugs.

[1hitsong]

This works as described for me.

@jimdogx You good?

@candry7731 Can you resolve the merge conflict?

[jimdogx]

This might be due to the conflicts, but if I run this branch on a movie that is partially watched (so I should see the "Resume" or "start over" popup), I am shown "Loading Movie" with a spinner that never goes away.

[github-actions]

This pull request has been inactive for 21 days and will be automatically closed in 7 days if there is no further activity.

[1hitsong]

Status: Pending code updates.

[candry7731]

This might be due to the conflicts, but if I run this branch on a movie that is partially watched (so I should see the "Resume" or "start over" popup), I am shown "Loading Movie" with a spinner that never goes away.

This should be fixed. Please test and let me know.

[sevenrats]

it's important that we restart the progress dialog in VideoPlayer.brs after we have closed it in startPlayBackOver.

[1hitsong]

From Home View, Click TV Episode from Continue Watching

• From popup click Go To Series. Spinner shows and doesn't go away
• From popup click Go To Season. Spinner shows and doesn't go away
• From popup click Go To Episode. Spinner shows and doesn't go away

[candry7731]

I'm also getting an error when clicking on the season...

[candry7731]

I'm working on these now.... Just fyi

[candry7731]

These are completed and ready for review

[1hitsong]

Functionality looks good. Just a few small finishing touches and it's done.

[1hitsong]

To be merged 2/12 unless an issue arises.