Graceful episode playback failure #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1hitsong
suggested changes
Feb 9, 2023
1hitsong
suggested changes
Feb 9, 2023
1hitsong
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#575 changed TVEpisodes.brs such that it attempts playback of failed media repeatedly because it hears the "OK" press that is used to close the error dialog and initiates playback logic. This causes the failed media to play over and over until "back" is pressed instead of "ok"
this pr removes the buttons from playback failure dialogs, forcing the user to press "back" instead. I don't love removing the ok button, but i don't see a better way.solved this issue by extending Dialog, and overloading the keypress listener to eat releases instead of presses. now works as expected with no compromises.
other changes: handle invalid runtimeticks and don't autoplay next episode if the last episode failed.
Issues
fixes #989