Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

how can i use in react native project? #198

Closed
fenglang0203 opened this issue Jul 1, 2022 · 5 comments
Closed

how can i use in react native project? #198

fenglang0203 opened this issue Jul 1, 2022 · 5 comments
Labels
question Further information is requested

Comments

@fenglang0203
Copy link

fenglang0203 commented Jul 1, 2022

how to import sdk in react native project

when I use this:

import {Jellyfin} from '@thornbill/jellyfin-sdk'

some warning as this:

Require cycle: node_modules/@thornbill/jellyfin-sdk/lib/discovery/index.js -> node_modules/@thornbill/jellyfin-sdk/lib/discovery/discovery-service.js -> node_modules/@thornbill/jellyfin-sdk/lib/index.js -> node_modules/@thornbill/jellyfin-sdk/lib/discovery/index.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
Require cycle: node_modules/@thornbill/jellyfin-sdk/lib/jellyfin.js -> node_modules/@thornbill/jellyfin-sdk/lib/discovery/index.js -> node_modules/@thornbill/jellyfin-sdk/lib/discovery/discovery-service.js -> node_modules/@thornbill/jellyfin-sdk/lib/index.js -> node_modules/@thornbill/jellyfin-sdk/lib/jellyfin.js

Require cycles are allowed, but can result in uninitialized values. Consider refactoring to remove the need for a cycle.
@thornbill
Copy link
Member

I attempted to look into this (it was working for me in an Expo app previously), but I encountered a different issue. I’ll try to have an answer/fix for you sometime this week. 🤞

@fenglang0203
Copy link
Author

Have you made any progress in react Native Project?

@thornbill thornbill added the question Further information is requested label Jul 11, 2022
@thornbill
Copy link
Member

The issue that I encountered should be fixed by #202 but that requires some additional work... I have not encountered the issue you are describing. What version of React Native are you using in your project?

@fenglang0203
Copy link
Author

I use 0.68.1 in my react native project

@thornbill
Copy link
Member

I did some testing with an app using Expo 45 which uses React Native 0.68.2 and it appears to be working fine there. If they are just warnings does it actually prevent the SDK from working correctly?

@thornbill thornbill closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants