Add normalize-url utility #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
added
bug
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 77 77
Lines 454 454
Branches 43 43
=======================================
Hits 418 418
Misses 36 36
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
cvium
approved these changes
Jul 12, 2022
thornbill
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This migrates from including
normalize-urlas a dependency to include a rewritten version directly as a utility function in the source. The modified version was ported to TypeScript and stripped of any unused functionality.This was done because the package has been a bit difficult to work with for awhile now...
v7 of
normalize-urlis only packaged as an ESM module making it difficult to work with in a lot of cases, due to ecosystem support not being great. The developer's position on ESM means this is unlikely to be fixed by an upstream change. This was in fact the entire reason for the v0.3.1 bugfix release.Unknowingly at the time, reverting to v6 introduced breakages in older browsers and react native due to the use of unsupported regex features. The developer has stated they will not accept backport fixes for v6.