Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tree-shaking of the SDK #149

Merged
merged 3 commits into from
Jun 17, 2022
Merged

Fix tree-shaking of the SDK #149

merged 3 commits into from
Jun 17, 2022

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Mar 16, 2022

  • Refactor getters for API classes to individual utility functions to allow for tree shaking.
  • Add list of breaking changes in next release.

Fixes #137

@thornbill thornbill added the enhancement New feature or request label Mar 16, 2022
@thornbill thornbill mentioned this pull request Mar 16, 2022
@thornbill thornbill changed the title Move api helpers to separate functions and use direct file imports Fix tree-shaking of the SDK Mar 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #149 (8543500) into master (1a69409) will increase coverage by 2.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #149      +/-   ##
==========================================
+ Coverage   83.56%   85.71%   +2.14%     
==========================================
  Files          17       77      +60     
  Lines         426      490      +64     
  Branches       44       44              
==========================================
+ Hits          356      420      +64     
  Misses         70       70              
Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/models/recommended-server-info.ts 100.00% <ø> (ø)
src/api.ts 100.00% <100.00%> (ø)
src/discovery/recommended-server-discovery.ts 100.00% <100.00%> (ø)
src/utils/api/activity-log-api.ts 100.00% <100.00%> (ø)
src/utils/api/api-key-api.ts 100.00% <100.00%> (ø)
src/utils/api/artists-api.ts 100.00% <100.00%> (ø)
src/utils/api/audio-api.ts 100.00% <100.00%> (ø)
src/utils/api/branding-api.ts 100.00% <100.00%> (ø)
src/utils/api/channels-api.ts 100.00% <100.00%> (ø)
... and 55 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a69409...8543500. Read the comment docs.

@thornbill thornbill marked this pull request as ready for review June 17, 2022 07:09
@thornbill thornbill merged commit 86270ae into master Jun 17, 2022
@thornbill thornbill deleted the shake-that branch June 17, 2022 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle size
2 participants