-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target ES6 properly #341
Target ES6 properly #341
Conversation
Codecov Report
@@ Coverage Diff @@
## master #341 +/- ##
==========================================
- Coverage 99.79% 99.79% -0.01%
==========================================
Files 78 78
Lines 493 482 -11
Branches 52 46 -6
==========================================
- Hits 492 481 -11
Misses 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a note in the breaking changes section of the README also? Thanks!
* Add the switch to ES6/ES2015 to the breaking changes section of the readme * Add the switch to Axios v1 major version to the breaking changes section of the readme
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@thornbill I took the liberty to also add the upgrade to Axios v1 at #300 to the breaking changes section. I also used 0.8.0 as the next logical step, but please ping me if you want me to use another versioning and I can fix it without any problem. |
See my previous fix at generator: OpenAPITools/openapi-generator#10308
See https://www.typescriptlang.org/tsconfig#target and https://www.typescriptlang.org/tsconfig#module
There's no tree shaking right now