Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move sonar reporting to GH action #576

Merged
merged 7 commits into from
Oct 14, 2023
Merged

Move sonar reporting to GH action #576

merged 7 commits into from
Oct 14, 2023

Conversation

thornbill
Copy link
Member

@thornbill thornbill commented Oct 11, 2023

Updates to using GH Actions to run the SonarCloud scans. This allows us to configure code coverage reporting so we can (hopefully) remove codecov and reduce some noise on PRs.

Screenshot of test coverage on sonar's summary for the PR:
Screenshot 2023-10-11 at 15-30-41 jellyfin-sdk-typescript - Jellyfin

@thornbill thornbill added ci This PR or issue mainly concerns CI github-actions Pull requests that update Github_actions code labels Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #576 (f39c70a) into master (71d1c21) will not change coverage.
Report is 45 commits behind head on master.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #576   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          82       82           
  Lines         569      569           
  Branches       54       54           
=======================================
  Hits          565      565           
  Misses          3        3           
  Partials        1        1           

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@thornbill thornbill merged commit b7fd1c7 into master Oct 14, 2023
7 checks passed
@thornbill thornbill deleted the sonar-gh-action branch October 14, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci This PR or issue mainly concerns CI github-actions Pull requests that update Github_actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants