Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stuck page titles on admin Dashboard #5686

Closed
BotBlake opened this issue Jun 9, 2024 · 2 comments · Fixed by #5735
Closed

Stuck page titles on admin Dashboard #5686

BotBlake opened this issue Jun 9, 2024 · 2 comments · Fixed by #5735
Labels
bug Something isn't working regression We broke something
Milestone

Comments

@BotBlake
Copy link

BotBlake commented Jun 9, 2024

Describe The Bug

The html page titles in the Admin Dashboard arent changing everywhere.
e.g. the DLNA Page sets it. If you go back to the "Home" admin Dashboard, the Page title still says "DLNA".

This happens for: DLNA, Notifications and Activity

Steps To Reproduce

  1. Go to the Admin Dashboard (through Jellyfin Web)
  2. Click on DLNA (or Notifications / Activity)
  3. See the Page title that matches the Tab you opened
  4. Click on any Tab that isnt DLNA, Notifications or Activity
  5. See the Page title still being the one from the previous page.
    --> This title only changes on theese three pages

Expected Behavior

The Title should reset when switching to another page,

Logs

Screenshots

grafik

System (please complete the following information):

  • Platform: TrueNAS Scale, Docker, Ubuntu,
  • Browser: Firefox, Chrome
  • Jellyfin Version: 10.9.6

Additional Context

@BotBlake BotBlake added the bug Something isn't working label Jun 9, 2024
@thornbill thornbill added this to the v10.9.7 milestone Jun 10, 2024
@thornbill thornbill added the regression We broke something label Jun 10, 2024
@thornbill
Copy link
Member

It seems there was some magic in the old drawer that would update the title when you clicked a link...

LibraryMenu.setTitle(text);

@thornbill thornbill modified the milestones: v10.9.7, v10.9.8 Jun 25, 2024
@venkat-karasani
Copy link
Contributor

identified the root cause, will fix and create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression We broke something
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants