Fix stuck page titles on admin dashboard #5735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thornbill
changed the title
thornbill
changed the title
thornbill
approved these changes
Jul 19, 2024
thornbill
pushed a commit
to thornbill/jellyfin-web
that referenced
this pull request
Jul 19, 2024
* Fixed stuck page titles on admin dashboard. * Updating contributors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The page title is being updated at setTitle method inside libraryMenu.js. Inside it we are listening to pageshow event and then getting the data-title attribute value and updating it as the page title. But, the admin views except some are missing these. I added these data-title attributes for the respective div and title prop for the respective Page components.
Issues
Fixes #5686