-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Progressive Web App for Android and iOS #304
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I support this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should go in the next minor release, it's a nice improvement.
It would need to be rebased off the release branch to make the release, but I'd be OK with that. |
There appear to be no merge conflicts... It's a pretty straightforward change tbh, with files we don't touch often. |
Let me know what you prefer. I could always fix things on my side and submit a new pull request with the release branch as source. |
You don't need a new PR. If you would like to keep this PR you can
|
Now on release-10.3.z |
Doesn't seem to pick up when jellyfin is being served at suburl [https://host.domain.com/emby]. |
Dug around a bit and you can get the suburl working by modifying the "start_url" entry in manifest.json from "/web/index.html" to "/emby/web/index.html" Given that the system is currently listening at /emby as well as the root url, is there any reason not to change this entry so that it works for both default and non-default users? (In the long run we'll hopefully get the ability to configure the listening url on the dashboard, at which point we'll need to link up that setting with the start_url entry in manifest.json -- not that I know how that could be accomplished.) |
Changes
This is an interesting replacement for an iOS app for Jellyfin. Launchcreens are a bit of a pain to implement since they must support every resolution available. If having all these links is problematic, I guess we could do without them but the launch screen will be white.
Before, the home screen link opened the browser and navigated to the jellyfin server:
Now, the home screen link appear as a native app: