Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various fixes for webOS 3.3 #309

Merged
merged 3 commits into from
May 9, 2019
Merged

Various fixes for webOS 3.3 #309

merged 3 commits into from
May 9, 2019

Conversation

oddstr13
Copy link
Member

@oddstr13 oddstr13 commented May 5, 2019

Changes

  • Add back Object.assign and fetch polyfills.
  • remove occurances of Promise.finally().
  • move functions out of if statements (strict mode)
  • make delayedError spit out a stack trace.

Issues
Fixes #306 (for webOS 3.3, not tested with webOS 2.0)

vitorsemeano
vitorsemeano approved these changes May 5, 2019
View reviewed changes
Copy link
Contributor

@vitorsemeano vitorsemeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me looks all fine.

thornbill
thornbill requested changes May 6, 2019
View reviewed changes
src/bower_components/alameda/alameda.js Show resolved Hide resolved
src/components/appRouter.js Show resolved Hide resolved
src/controllers/loginpage.js Show resolved Hide resolved
@oddstr13
Additional fixes to get jf-web loading in webOS 3.0 emulator.
3167c7d 
Can't seem to get any audio/video playing in the emulator,
so I'm not sure if the emulator supports multimedia playback.
@oddstr13 oddstr13 mentioned this pull request May 8, 2019
Merged
5 tasks
@anthonylavado anthonylavado merged commit 8840c15 into jellyfin:release-10.3.z May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitorsemeano vitorsemeano vitorsemeano approved these changes

@thornbill thornbill thornbill approved these changes

@anthonylavado anthonylavado anthonylavado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@oddstr13 @anthonylavado @thornbill @vitorsemeano