Resolve some android seeking issues #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkanada
approved these changes
May 17, 2019
joshuaboniface
approved these changes
May 17, 2019
|
Where can I get the apk for this tracking issue fix? I am using the 0.9.0 release and still experience the inability to skip or resume a video. |
|
@fromage9747 The last upload of 0.9.0 used an old build of certain modules for some reason. We will be making a new one soon. |
|
So essentially, the new apk build will have the seeking issue fixed? Because for me as well, this is the biggest drawback right now. |
|
plz seeking is important to me plz fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this allows android to seek, but I think there's more to it than this quick fix - the cordova app seems to be getting transcodes / remuxes when it is not fully necessary which makes this bug worse.
Changes
Prevents a removal of the startPositionTicks variable so that the progress bar is not reset to 0:00 when seeking
Issues
#263
possibly jellyfin/jellyfin-android#133