Fix imports #4912
Merged
Fix imports #4912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitrylyzo
added
bug
dmitrylyzo
commented
Oct 24, 2023
| @@ -13,9 +13,11 @@ import * as userSettings from '../../scripts/settings/userSettings'; | |||
| import cardBuilder from '../cardbuilder/cardBuilder'; | |||
| import itemContextMenu from '../itemContextMenu'; | |||
| import '../cardbuilder/card.scss'; | |||
| import '../../elements/emby-button/emby-button'; | |||
| import '../../elements/emby-itemscontainer/emby-itemscontainer'; | |||
There was a problem hiding this comment.
emby-itemscontainer can be removed (no direct use in remotecontrol.js), but I didn't want to risk 😅
According to the template.
dmitrylyzo
force-pushed
the
fix-imports
branch
from
261666e
to
5dad4b4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
thornbill
approved these changes
Oct 24, 2023
thornbill
pushed a commit
that referenced
this pull request
Nov 8, 2023
Fix imports Original-merge: 1a17353 Merged-by: Bill Thornton <thornbill@users.noreply.github.com> Backported-by: Bill Thornton <thornbill@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
According to the template.
Issues
In webOS 1.2,
mastercrashes becauseemby-slideris not loaded.10.8 doesn't crash (probably due to a poor tree-shaking), but I don't think we should leave a potential bug in the build.