Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FLAC Audio in Video Support for Tizen #4938

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

rafma0
Copy link
Contributor

@rafma0 rafma0 commented Nov 4, 2023

I opened this issue here jellyfin/jellyfin#10504 where I explain it better (wrong repo).

Basically, FLAC support on Samsung is weird. In their documentation, they don't claim to support it, but you can play it. However, you will probably get audio and video that are not synced most of the time. I also tested and found that Plex transcodes FLAC audio in videos for Samsung, and I found a post in the Emby forums (linked in the issue I opened) where they update it to do the same.

Changes
Remove FLAC audio in video support for Tizen

@rafma0 rafma0 requested a review from a team as a code owner November 4, 2023 00:36
@dmitrylyzo dmitrylyzo added bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback labels Nov 5, 2023
Copy link
Contributor

@dmitrylyzo dmitrylyzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On my NU7400 (Tizen 4) FLAC has ~1s delay in MKV and no sound in MP4.

src/scripts/browserDeviceProfile.js Show resolved Hide resolved
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jellyfin-bot
Copy link
Collaborator

Cloudflare Pages deployment

Latest commit 517feb7
Status ✅ Deployed!
Preview URL https://38297e45.jellyfin-web.pages.dev
Type 🔀 Preview

View build logs
View bot logs

@thornbill thornbill added this to the v10.9.0 milestone Nov 9, 2023
@thornbill thornbill merged commit 6498758 into jellyfin:master Nov 9, 2023
23 checks passed
@rafma0 rafma0 deleted the fix-tizen-flac branch November 9, 2023 18:00
nyanmisaka added a commit to nyanmisaka/jellyfin-web that referenced this pull request Nov 29, 2023
…4938)

Signed-off-by: nyanmisaka <nst799610810@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working p: tizen This PR or issue mainly concerns Tizen clients playback This PR or issue mainly concerns playback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants